The Cherno
patreon
He wrote this out BY HAND? // Full Code Review
🕑 Added 2024-10-18 06:43:12 +0000 UTCHey all! Trying something new here - longer more in-depth code reviews just for you Patrons! Let me know what you thought of this video, and if you have any follow up questions, I'll take a look for the next video.
And of course, if you have any code of your own you'd like me to review, send it in to chernoreview@gmail.com and mention that you're a Patron in the subject, and I'll do my best to review it. Thank you so much for your support! ❤️
Here's the code from this video ► https://github.com/sorumehta/skyward-scammer
Comments
Sluggo
Love the in-depth code review, I usually watch videos at 1.25X, yours I have to watch at 0.75X (you sound kind of drunk but that's fine) so I can keep up. I think you pretty much hit the mark on this one.
James Palermo
I think on Patreon I’d prefer the extra time being spent less on line by line refactoring and rapid commentary and see some more in depth drilling down on the fundamental motivation behind design mistakes or changes you feel are important. For example with the section of array members for sprites: I now know consistency between vec and array is important, it’s better to just have the engine pull in from a folder, and I should never use strings for file paths. But why exactly… I’m not sure. Basically whenever you have said something like “I don’t even know if this is worth going into” or “this is probably beyond the scope” that’s when I’m like “Yes it is worth it! Go into it!” Use the review framing as a launching pad to teach concepts. TBH an hour of context-shifting around a code base doing refactoring advice is a bit much.
